feat: Ignore FROM args when pre-pulling images

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.

https://dotnet.testcontainers.org

MIT License

3.73k stars 262 forks source link

feat: Ignore FROM args when pre-pulling images #1016

Closed HofmeisterAn closed 11 months ago

HofmeisterAn commented 11 months ago

What does this PR do?

Besides the changes made to the docs, the pull request changes the way we resolve base images from Dockerfiles. It ignores arguments like --platform following the FROM statement and pre-pulls the actual image.

Why is it important?

The previous implementation omitted those images and did not pre-pull them. @MartinSchmidt, I believe these changes will accommodate your use case. Could you possibly test it? Your feedback would be appreciated.

Related issues

Closes #993

netlify[bot] commented 11 months ago

Deploy Preview for testcontainers-dotnet ready!

Name	Link
Latest commit	b4f26896239bc59965e7764c50f26084ffa8d8a4
Latest deploy log	https://app.netlify.com/sites/testcontainers-dotnet/deploys/651efd3e77b9c400083868e7
Deploy Preview	https://deploy-preview-1016--testcontainers-dotnet.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.