fix: Prevent invalid negative timestamps getting container logs

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.

https://dotnet.testcontainers.org

MIT License

3.67k stars 254 forks source link

fix: Prevent invalid negative timestamps getting container logs #1038

Closed mausch closed 8 months ago

mausch commented 8 months ago

What does this PR do?

Fixes https://github.com/testcontainers/testcontainers-dotnet/issues/1035

The other way to go about this would be fixing the arguments at callsites and throwing in this GetLogsAsync() method if the value is negative... though it feels that should be the job of Docker.DotNet.

Why is it important?

explained in https://github.com/testcontainers/testcontainers-dotnet/issues/1035

Related issues

netlify[bot] commented 8 months ago

Deploy Preview for testcontainers-dotnet ready!

Name	Link
Latest commit	ba76abbc2c0b2cf66a888b1d9083454ab689067c
Latest deploy log	https://app.netlify.com/sites/testcontainers-dotnet/deploys/6541f88bef91ec00085b533e
Deploy Preview	https://deploy-preview-1038--testcontainers-dotnet.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.