search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.77k stars 271 forks source link

fix: Retain the internal Couchbase builder configuration if the user overrides the default configuration #1040

Closed HofmeisterAn closed 11 months ago

HofmeisterAn commented 11 months ago

What does this PR do?

The PR makes the internal configurations that are not exposed to the public (yet) static. This keeps the configuration the same for all Couchbase builder instances.

Why is it important?

With the previous configuration, the user could "override" certain parts of the internal default configuration (the enabled services), leading to inconsistent results in readiness checks.

Related issues

netlify[bot] commented 11 months ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 9d9272088ec45a69aa2c9b8d2831272de3e8746d
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6542766a7921d90008594ee6
Deploy Preview https://deploy-preview-1040--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.