search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.77k stars 271 forks source link

feat: Add Bigtable module #1046

Closed peroyhav closed 10 months ago

peroyhav commented 11 months ago

Add Bigtable emulator container

netlify[bot] commented 11 months ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 5396fd61a8f133edce634f6badde2c92e98b913d
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65610e9b48e2830008d0b562
Deploy Preview https://deploy-preview-1046--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

peroyhav commented 11 months ago

Trying to force update to check if tests failed due to error on my part, or some issue elsewhere. No report of failure found.

peroyhav commented 11 months ago

@HofmeisterAn I believe this is ready for review. Using the BigtableTableAdminClient to test that it works as expected by creating and retrieving a table.

HofmeisterAn commented 11 months ago

@HofmeisterAn I believe this is ready for review. Using the BigtableTableAdminClient to test that it works as expected by creating and retrieving a table.

Thank you for the PR. I'll review it within the next few days as soon as I have some free time 🕐. I've already taken a brief look, and it seems good so far.

peroyhav commented 10 months ago

Thank you for the contribution, pull request and for addressing the change requests. PR looks good 🙏.

Thanks, will the Bigtable module be available upon next release, and when approximately can I expect it to be available?

HofmeisterAn commented 10 months ago

Yes, it will be included in the next release. There is no ETA yet (I do not think it is urgent, you can always fall back on the generic builder). I would like to include a couple more features; having a preview of the reusable API would be awesome.

peroyhav commented 10 months ago

No problem, I've used copyed the implementation into the project where I needed it anyway, just want to throw the code out to reduce code lines required to maintain within the projects.