chore: Update .NET SDK to version 8 (LTS)

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.

https://dotnet.testcontainers.org

MIT License

3.67k stars 254 forks source link

chore: Update .NET SDK to version 8 (LTS) #1054

Closed HofmeisterAn closed 8 months ago

HofmeisterAn commented 8 months ago

What does this PR do?

Updates the .NET SDK to version 8 (latest LTS).

Why is it important?

We are trying to run our tests utilizing the latest .NET SDK (LTS). Testcontainers itself, including the modules, still targets netstandard2.0 and netstandard2.1 to provide support for most .NET Framework and .NET versions.

Related issues

netlify[bot] commented 8 months ago

Deploy Preview for testcontainers-dotnet ready!

Name	Link
Latest commit	d9fdaf93197dc19bb44aaa792b2c8c4a54283ff7
Latest deploy log	https://app.netlify.com/sites/testcontainers-dotnet/deploys/655e42dbacd0d30008902e96
Deploy Preview	https://deploy-preview-1054--testcontainers-dotnet.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0xced commented 7 months ago

Note that SourceLink is now included in the .NET SDK:

Source Link is now included in the .NET SDK. The goal is that by bundling Source Link into the SDK, instead of requiring a separate <PackageReference> for the package, more packages will include this information by default. That information will improve the IDE experience for developers.

Since the global.json file requires the .NET 8 SDK, all the package references to Microsoft.SourceLink.GitHub could be removed instead of updated to version 8.0.0.

HofmeisterAn commented 7 months ago

Thanks for sharing. I will remove it in the next few days 🧹.