Closed ShirAvneri closed 7 months ago
Name | Link |
---|---|
Latest commit | 8e2d55439db0f74ee41fa72203eeabf3c89d142a |
Latest deploy log | https://app.netlify.com/sites/testcontainers-dotnet/deploys/65651c7ac8c3a90008e3d274 |
Deploy Preview | https://deploy-preview-1055--testcontainers-dotnet.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Nowadays, we can find ActiveMQ Classic and ActiveMQ Artemis. Although, the module refers to activemq, in general, would be great to be specific about Artemis instead of ActiveMQ. In Testcontainers for Java, the plan is to have one module to host both of them.
@eddumelendez I can also include the classic container in this project, if that is okay? Or should they be hosted in different projects?
ActiveMQ Classic doesn't support credentials in env vars right now, the image have not been published yet, that's why the PR is still open in Testcontainers for Java.
My comment is related to the naming rather than adding support for ActiveMQ Classic.
@eddumelendez Is there anything left we should address before merging the PR?
Great! Once released I'll merge the changes to make it available in the Modules Catalog. You can see the preview here.
What does this PR do?
Adds an ActiveMQ Artemis container to the list of supported Testcontainers.
Why is it important?
Provides an ActiveMQ Artemis test container.
How to test this PR
Run Testcontainers.ActiveMq.Tests