search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.67k stars 254 forks source link

chore: Replace custom wait strategy with default strategies #1059

Closed ShirAvneri closed 7 months ago

ShirAvneri commented 7 months ago

What does this PR do?

Replacing redundant custom wait strategy implementations with the corresponding IWaitForContainerOS methods.

Why is it important?

Ensuring all modules are consistent and removing redundant code.

How to test this PR

Run the corresponding tests projects for the changed modules.

netlify[bot] commented 7 months ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit d1c0e325e7d4e2ddad0dde50bbf471897d3693b4
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/656ce76a8b28cd0008e22254
Deploy Preview https://deploy-preview-1059--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShirAvneri commented 7 months ago

@HofmeisterAn can you please review?

HofmeisterAn commented 7 months ago

Thanks for the PR. I would like to keep some of the previous implementations, but most of it looks good. Thanks!