feat: Add CockroachDB module

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.

https://dotnet.testcontainers.org

MIT License

3.77k stars 271 forks source link

feat: Add CockroachDB module #1077

Closed rafaumlemos closed 8 months ago

rafaumlemos commented 9 months ago

What does this PR do?

Introduces Testcontainers.CockroachDB to the project

Why is it important?

It's important to support CockroachDB

Related issues

How to test this PR

I implemented the same test logic used by PostgreSQL as a reference

Follow-ups

The implementation closely resembles that of PostgreSQL

netlify[bot] commented 9 months ago

Deploy Preview for testcontainers-dotnet ready!

Name	Link
Latest commit	2d362d3a9bc8cef7615b7d8e6948de81e0b01e76
Latest deploy log	https://app.netlify.com/sites/testcontainers-dotnet/deploys/65b3dfc56abdc10009fafc7d
Deploy Preview	https://deploy-preview-1077--testcontainers-dotnet.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rafaumlemos commented 9 months ago

Ready for review.

Thanks @HofmeisterAn for some extra help.

HofmeisterAn commented 9 months ago

FYI: I have not forgotten to review the PR. I will do it at the latest when I am back from the holidays.

rafaumlemos commented 8 months ago

@HofmeisterAn @eddumelendez

Ready for review again; I've resolved the conflicts due to the new changes in the develop branch.

HofmeisterAn commented 8 months ago

@rafaumlemos, sorry for the delay. I am very busy right now. I just had the time to review your pull request. The PR looks good. Thanks for the contribution 🥳! I will merge the PR later.