testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.65k stars 250 forks source link

chore: Always run the Upload Test And Coverage Results step #1113

Closed 0xced closed 4 months ago

0xced commented 4 months ago

Use if: always()instead of if: true in order to always run a step even if the previous one fails. This is surprising but that's how GitHub actions work, see https://stackoverflow.com/questions/58858429/how-to-run-a-github-actions-step-even-if-the-previous-step-fails-while-still-f#comment112735158_58859404

Proof that if: true does not work.

Screenshot 2024-02-11 at 13 24 19
netlify[bot] commented 4 months ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 862500b8fa2bd57f69c7c2bd1c3cf7004a67f408
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/65c8bccbedb07a0007cc1aa6
Deploy Preview https://deploy-preview-1113--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.