search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.65k stars 250 forks source link

fix: Add default file permission (755 for image build) #1176

Closed HofmeisterAn closed 1 month ago

HofmeisterAn commented 1 month ago

What does this PR do?

Applies the default file permission (755) in the tarball that is later sent to the Docker daemon to build the image.

Why is it important?

Without setting the default permissions on Windows test hosts, the relevant ENTRYPOINT and CMD commands may not be able to access (read) files from the working directory (if the user context changes).

Related issues

netlify[bot] commented 1 month ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 616b77ef4e26bbdd2b440011502dca994b68e84d
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/664231c536d864000859f489
Deploy Preview https://deploy-preview-1176--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danielcrabtree commented 1 month ago

Looks good to me. Thanks for getting this fixed.