testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.65k stars 250 forks source link

[Enhancement]: Add Support for Aspire Standalone Dashboard #1190

Open NikiforovAll opened 4 weeks ago

NikiforovAll commented 4 weeks ago

Problem

As a developer, I want to be able to use Test Monitoring, Aspire provides great local dev experience for that

Ref: https://www.honeycomb.io/blog/monitoring-unit-tests-opentelemetry

Solution

Add Testcontainers.AspireDashboard to this repository.

Benefit

The test monitoring scenario is covered.

Alternatives

It is quite easy to configure AspireDashboard based on common abstractions, but I think it makes good use for others. This is why I would like to contribute to this repo by adding this package.

Would you like to help contributing this enhancement?

Yes

HofmeisterAn commented 3 weeks ago

Interesting idea, thanks for sharing the article. I think I could use something like this in another project. You mentioned you are interested in contributing a module; do you need any guidance or have questions on how to start? I doubt I have time to begin the implementation soon, but I can certainly provide support with feedback and reviews.

NikiforovAll commented 3 weeks ago

I think I can do something based on the following: https://github.com/NikiforovAll/tests-instrumentation-with-otel-and-aspire

I would be happy to contribute, I will take a look at the documentation

ref: https://github.com/NikiforovAll/tests-instrumentation-with-otel-and-aspire/blob/main/tests/Api.IntegrationTests/WebAppFixture.cs

NikiforovAll commented 3 weeks ago

I have design-related questions:

  1. It only makes sense to use Aspire with reusable value and persist it during test runs, do we want to make it as default?
  2. It makes sense to expose Aspire on the well-known port by default 18888. What do you think?