testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.65k stars 250 forks source link

chore: Remove PulsarContainer.CreateAuthenticationTokenAsync(TimeSpan) default arg #1195

Closed entvex closed 3 weeks ago

entvex commented 3 weeks ago

What does this PR do?

This update modifies the CreateAuthenticationTokenAsync to accept an expiry time, including an option for infinite expiration. In addition, the PulsarContainerTest and Pulsar documentation have been updated accordingly.

Why is it important?

It’s essential for end users to have clarity about the lifespan of a token. By requiring them to set an expiry time, any uncertainty is eliminated. Additionally, we now offer support for tokens that never expire.

How to test this PR

This is covered by the updated tests

netlify[bot] commented 3 weeks ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 13679a36f03c720be60e0b08257a8b630e8b55b1
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6669603d7f073b00085e16a0
Deploy Preview https://deploy-preview-1195--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.