search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.82k stars 279 forks source link

[Enhancement]: Upgrade Testcontainers.Pulsar to use Apache Pulsar v4.0.0 #1291

Open keshramjith opened 2 weeks ago

keshramjith commented 2 weeks ago

Problem

Upgrade docker image of Testcontainers.Pulsar to Apache Pulsar v4.0.0

Solution

Changing docker image version and any other necessary changes required for Apache Pulsar v4.0.0

Benefit

Using the latest LTS version of Apache Pulsar

Alternatives

None

Would you like to help contributing this enhancement?

Yes

keshramjith commented 2 weeks ago

Please add the module label, I'm not sure how to do that

HofmeisterAn commented 2 weeks ago

Thanks for creating the issue. Do you know if any changes to the module are necessary? Could you simply override the default image instead? Typically, we try to avoid changing the default image version to prevent introducing breaking changes; instead, we recommend developers to pin the version.

keshramjith commented 2 weeks ago

Yes, I did try overriding the image with .WithImage(), however I encountered a bunch of issues and some module changes are required.

HofmeisterAn commented 2 weeks ago

I see, thanks for the clarification. In this case, we usually make the necessary changes but try to support both configurations and ensure backward compatibility.