search

testcontainers / testcontainers-dotnet

A library to support tests with throwaway instances of Docker containers for all compatible .NET Standard versions.
https://dotnet.testcontainers.org
MIT License
3.73k stars 262 forks source link

chore: Update BouncyCastle.Cryptography to 2.2.1 (previous Portable.BouncyCastle) #985

Closed jcmrva closed 1 year ago

jcmrva commented 1 year ago

Dependency update.

What does this PR do?

Moving back to the main distro of BouncyCastle.Crypto now that it supports netstandard etc. https://www.nuget.org/packages/BouncyCastle.Cryptography

Why is it important?

Portable.BouncyCastle hasn't been updated in almost 2 years, and I assume Claire didn't intend to own it forever.

Related issues

n/a (that I know of)

How to test this PR

This builds but the tests have some failures I'm not able to diagnose; also the test process stalled on the last step (see gist) for more than 15 minutes before I killed it. https://gist.github.com/jcmrva/c83912eb5834b4c0d67f07671b0771d0

netlify[bot] commented 1 year ago

Deploy Preview for testcontainers-dotnet ready!

Name Link
Latest commit 6654a9af9dfc46287b715d367c01b62c0fff3f2b
Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64ee80f877a1960008bc8a7e
Deploy Preview https://deploy-preview-985--testcontainers-dotnet.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jcmrva commented 1 year ago

Yeah, I'm fairly sure it has something to do with my setup, although I'm also on Windows with Docker Desktop. I'll see if I can discover more about what's going on.