feat: add testcontainers labels to the built images

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.

https://golang.testcontainers.org

MIT License

3.3k stars 450 forks source link

feat: add testcontainers labels to the built images #2579

Closed mdelapenya closed 2 weeks ago

mdelapenya commented 3 weeks ago

What does this PR do?

This PR adds the default labels to the images that are built from a Dockerfile.

Why is it important?

It will add the images to Ryuk death notes.

Related issues

Relates #1484

netlify[bot] commented 3 weeks ago

Deploy Preview for testcontainers-go ready!

Name	Link
Latest commit	4d32b7d5fdf5185dbca908be21d278356dee9800
Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/6669909e9ec0050008e648ce
Deploy Preview	https://deploy-preview-2579--testcontainers-go.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mdelapenya commented 2 weeks ago

I've been internally checking with the Docker team responsible for building images, and they confirm that this fix will not apply to all the interstitial images. They also share the implications for doing that are not trivial, and would need more work from the build site.

Even though this is not the right fix for all the interstitial images, merging this is convenient for the images built by Testcontainers, that's why I'm going to merge this one.

I'm also changing the type of the issue, from chore to feature, as it will add a new behaviour, which is removing the built images (is it a feature is it a bug? 😅)