search

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.
https://golang.testcontainers.org
MIT License
3.3k stars 450 forks source link

chore(deps): bump github.com/docker/docker from v25.0.5 to v26.1.4 #2584

Closed thaJeztah closed 2 weeks ago

thaJeztah commented 2 weeks ago

What does this PR do?

Updating the docker dependency to the current release.

Why is it important?

Related issues

netlify[bot] commented 2 weeks ago

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit e434d06e6dc7a0c4e7c91e97482859004c0de748
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/666cbf199843f40008d88e56
Deploy Preview https://deploy-preview-2584--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thaJeztah commented 2 weeks ago

Think I have them all and changed them all back 😄

mdelapenya commented 2 weeks ago

Thanks for this! I'm enabling the CI now

mdelapenya commented 2 weeks ago

Oh you probably need to run make lint locally to detect and fix the deprecations

thaJeztah commented 2 weeks ago

oh! good one; I should've read the docs; let me check

mdelapenya commented 2 weeks ago

I should've read the docs

if the docs include reading the GH workflow, then you are right... otherwise it's my fault not having the CONTRIBUTING guidelines up-to-date 🙈

thaJeztah commented 2 weeks ago

Yup, looks like I missed one type 😂 I think it's ok now 🤞

mdelapenya commented 2 weeks ago

Perfect, lint passed! 🚀 Waiting for the CI to merge

thaJeztah commented 2 weeks ago

Hm... looks like some failures 🤔 fun!

run golangci-lint
  Running [/home/runner/golangci-lint-1.55.2-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=modules/artemis --verbose] in [/home/runner/work/testcontainers-go/testcontainers-go/modules/artemis] ...
  Error: undefined: testcontainers (typecheck)
  Error: undefined: testcontainers (typecheck)
  Error: undefined: testcontainers (typecheck)
  Error: c.PortEndpoint undefined (type *Container has no field or method PortEndpoint) (typecheck)
  Error: c.PortEndpoint undefined (type *Container has no field or method PortEndpoint) (typecheck)
thaJeztah commented 2 weeks ago

I don't see that locally; or at least, don't see something immediately wrong in here; https://github.com/testcontainers/testcontainers-go/blob/2681ae411908eb9b8858d3e5b608598c647fe508/modules/artemis/artemis.go#L38

thaJeztah commented 2 weeks ago

Wondering if it's golangci-lint needing an update for newer Go versions 🤔 

golangci/golangci-lint-action@9d1e0624a798bb64f6c3cea93db47765312263dc
  with:
    version: v1.55.2
    working-directory: modules/artemis
    args: --verbose
    skip-cache: true
    github-token: ***
    only-new-issues: false
    skip-save-cache: false
    install-mode: binary
  env:
    TESTCONTAINERS_RYUK_DISABLED: false
    RYUK_CONNECTION_TIMEOUT: 60s
    RYUK_RECONNECTION_TIMEOUT: 10s
mdelapenya commented 2 weeks ago

Let me try to lint all modules locally 🙏

mdelapenya commented 2 weeks ago

Each submodule needed to mod-tidy again, I ran make tidy-all for that. This brings me the chance to improve the contributing docs ASAP

thaJeztah commented 2 weeks ago

oh! missed that one; thanks!

mdelapenya commented 2 weeks ago

@thaJeztah https://github.com/testcontainers/testcontainers-go/pull/2586