fix: simplify fully-qualified image names

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.

https://golang.testcontainers.org

MIT License

3.67k stars 504 forks source link

fix: simplify fully-qualified image names #2846

Closed mdelapenya closed 1 month ago

mdelapenya commented 1 month ago

What does this PR do?

This PR removes all the prefixes for docker.io from the images used in 1) tests for the library, 2) modules

Why is it important?

It's better to ask for "nginx:latest" and let the engine deal with the image references than to enforce an invalid docker registry.

If we wanted to be explicit about official images, we should have used https://index.docker.io/v1/library/nginx:latest instead.

It also removes a bug when using Docker Desktop, as it considered those images were not accessible for the already used docker credentials.

netlify[bot] commented 1 month ago

Deploy Preview for testcontainers-go ready!

Name	Link
Latest commit	f4d36c439e70747d3a69a3fa4ced46505dd678ed
Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/6718cfcebe959100083f633c
Deploy Preview	https://deploy-preview-2846--testcontainers-go.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh commented 1 month ago

Oh if the concern is about *.io going away what about https://index.docker.io/v1/?