search

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.
https://golang.testcontainers.org
MIT License
3.68k stars 504 forks source link

refactor(cockroachdb): to use request driven options #2883

Open stevenh opened 2 weeks ago

stevenh commented 2 weeks ago

Refactor cockroachdb module to to use request driven options simplifying the flow.

Clean up tests eliminating the use of suite which significantly speeds up test runs.

netlify[bot] commented 2 weeks ago

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 83a78384183bd6a75fb5f9924cff84ab47838f77
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6740cfcb162998000802f123
Deploy Preview https://deploy-preview-2883--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh commented 2 weeks ago

This should be split out into components if we want to go down this route.

stevenh commented 3 days ago

I did an initial pass and the overall feedback is positive. I detected the following possible chunks of separate PRs, please tell me what you think:

  1. wait.walk for traversing multi strategies
  2. wait for TLS
  3. cockroachdb refactor

I think it would be much clearer for the review, but also for the release notes, as consumers would discover the new wait strategies as part of it.

That's pretty much my thought's too, which is why I've left in draft.