testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.
https://golang.testcontainers.org
MIT License
3.67k stars 504 forks source link

fix(redpanda): temporary file use #2884

Closed cavus700 closed 1 week ago

cavus700 commented 1 week ago

What does this PR do?

The Redpanda container does not write files to the local filesystem anymore. It uses io.Reader now to copy files to the container.

Why is it important?

On some environment it is not possible to write the startup files to the local filesystem and mount them into the container. For example in CI/CD environments where docker in docker is used. The files are written to the filesystem of container A. Then container A tries to start the redpanda container and passes the mount path to the newly created container. The redpanda container tries to mount the files from the host filesystem but cannot find them because they were written inside container A.

How to test this PR

Just run the container tests. Everything should be working like before.

netlify[bot] commented 1 week ago

Deploy Preview for testcontainers-go ready!

Name Link
Latest commit 63bbd4ee14c7cda2bd8b646da6634c2c81f6318a
Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67333cc4e9f94c000862d863
Deploy Preview https://deploy-preview-2884--testcontainers-go.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.