fix: do not run sonar upload when ryuk is disabled

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.

https://golang.testcontainers.org

MIT License

3.67k stars 504 forks source link

fix: do not run sonar upload when ryuk is disabled #2889

Closed mdelapenya closed 4 days ago

mdelapenya commented 4 days ago

What does this PR do?

Skips the upload to sonar of the artifacts when Ryuk is disabled, to avoid name conflicts.

Why is it important?

There is no need to measure metrics when Ryuk is disabled.

Related issues

Caused by #2888

netlify[bot] commented 4 days ago

Deploy Preview for testcontainers-go ready!

Name	Link
Latest commit	199c6347724cff3587daf1110dadc34f6396a2ec
Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/673b1f1ed87fd900081bc12f
Deploy Preview	https://deploy-preview-2889--testcontainers-go.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.