fix: only upload to sonar on ubuntu-latest

testcontainers / testcontainers-go

Testcontainers for Go is a Go package that makes it simple to create and clean up container-based dependencies for automated integration/smoke tests. The clean, easy-to-use API enables developers to programmatically define containers that should be run as part of a test and clean up those resources when the test is done.

https://golang.testcontainers.org

MIT License

3.67k stars 504 forks source link

fix: only upload to sonar on ubuntu-latest #2891

Closed mdelapenya closed 4 days ago

mdelapenya commented 4 days ago

What does this PR do?

Excludes the upload of the sonar files to only those test jobs using ubuntu-latest.

Why is it important?

Because basename does not exist on Windows, and we don't actually want to upload the coverage for windows atm, it's better to keep it simple for now.

Related issues

Follow-ups #2890, #2889 #2888

Follow-ups

We must probably need a dedicated issue to target sonar integration. Let's do it after #2876 is merged

netlify[bot] commented 4 days ago

Deploy Preview for testcontainers-go ready!

Name	Link
Latest commit	9bb4d4fa46ffe64ca212ece4bad14d89050227f8
Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/673b5f41126059000827c252
Deploy Preview	https://deploy-preview-2891--testcontainers-go.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.