testcontainers / testcontainers-hs

Docker containers for your integration tests! http://hackage.haskell.org/package/testcontainers
MIT License
56 stars 12 forks source link

Have two different packages for Hspec and Tasty #19

Open michivi opened 1 year ago

michivi commented 1 year ago

Question

Would it be possible to have two different packages, one for Hspec and one for Tasty?

Currently, when one chooses to use Hspec (resp. Tasty), they also have to compile Tasty (resp. Hspec) as testcontainers-hs uses both as dependencies. But they won't actually use it.

Perhaps having something like this could help:

Do you think something like that would be doable? Thanks in any case 🙂

alexbiehl commented 1 year ago

Sure definitely doable. Happy to accept contributions. But my question is, does it really matter? Compiling dependencies is a one time thing, no?

michivi commented 1 year ago

Right, but it still feels unnecessary to build tasty and its dependencies when we're using hspec. In CI, we would also use unnecessary storage for the compiled binary, though surely not significantly to be important. In any case, I guess this sure sounds low-priority as nothing is broken. If I have time, I'll try to tackle it 🙂

alexbiehl commented 1 year ago

Sounds good!