search

testcontainers / testcontainers-hs

Docker containers for your integration tests! http://hackage.haskell.org/package/testcontainers
MIT License
58 stars 13 forks source link

Test with GHC 9.2.4 and 9.4.2 in CI #25

Closed jhrcek closed 1 year ago

jhrcek commented 1 year ago

Hello @alexbiehl I'd like to use this library in our project but at the moment it doesn't build with when using ghc 9.2.4 and more recent versions of Aeson. Could you please accept this PR to help me fix that?

Note that I overhauled ci config to test latest patch version of each recent minor version of GHC.

jhrcek commented 1 year ago

Actually please wait a bit with merging, I figured we could take advantage of IsString typeclass that both Text and Aeson.Key implement and that way get rid of all the CPP stuff. Also I just tried and it seems to work with ghc 9.4.2, so why not add that to CI as well.

jhrcek commented 1 year ago

All GHCs passed in CI in my fork: https://github.com/jhrcek/testcontainers-hs/actions/runs/3320353421/jobs/5486631895 I consider it ready to merge.

alexbiehl commented 1 year ago

@jhrcek is your usage of the library open source? Would it be possible for you to link to your repo/tests for a real world example?

jhrcek commented 1 year ago

Unfortunately it's not. It's an application that lives as private repo under https://github.com/Holmusk/

jhrcek commented 1 year ago

Hello @alexbiehl ould you please release ghc-9.2.x supporting version to hackage? We're already using master branch of this repo with 9.2.5, but we'd like to switch to hackage dependency instead.