search

testcontainers / testcontainers-hs

Docker containers for your integration tests! http://hackage.haskell.org/package/testcontainers
MIT License
56 stars 12 forks source link

Bounds for network dependency is incorrect for 0.5.0.0 #38

Closed belevy closed 5 months ago

belevy commented 1 year ago

In the updated version of the package the openSocket helper from network-3.1.2 is being used.

Since this is just a helper and that version is fairly new it probably would be better (read, I would prefer) to switch to using socket directly rather than bump the dependency.

That said, since the code on Hackage is immutable you should probably change the bounds for 0.5.0.0

alexbiehl commented 1 year ago

Thanks for reporting the issue @belevy. I did make a Hackage revision correcting the bounds and also pushed https://github.com/testcontainers/testcontainers-hs/pull/39 to fix the issue with the next minor release.

belevy commented 1 year ago

Awesome, thank you so much for your prompt response.