search

testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.org
MIT License
8.03k stars 1.65k forks source link

Values from docker-java.properties are ignored in EnvironmentAndSystemPropertyClientProviderStrategy #3462

Open bojanv55 opened 4 years ago

bojanv55 commented 4 years ago

Seems that new releases of testcontainers broke my setup.

Here is a link with the problematic line and proposed solution:

https://github.com/testcontainers/testcontainers-java/commit/8e57ae60565f24c01ec7ef964dc37130a022eba4#r44075175

bsideup commented 4 years ago

Hi @bojanv55,

Sorry for this regression! Would you like to submit a PR with a fix?

sgoryachkin commented 3 years ago

Also the problem with the configuration via maven-surefire-plugin

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <configuration>
        <systemPropertyVariables>
            <DOCKER_HOST>tcp://172.31.139.72:2375</DOCKER_HOST>
        </systemPropertyVariables>
     </configuration>
</plugin>

The strategy is not applicable but DockerClientConfig successfully receives data from System.properties