testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.org
MIT License
7.98k stars 1.64k forks source link

[Enhancement]: Support different docker context #5837

Open diegolovison opened 2 years ago

diegolovison commented 2 years ago

Module

Core

Proposal

% docker context ls
NAME                  DESCRIPTION                               DOCKER ENDPOINT                                  KUBERNETES ENDPOINT                                           ORCHESTRATOR
default               Current DOCKER_HOST based configuration   unix:///var/run/docker.sock                      https://api.xpto.net:6443 (dlovison)   swarm
desktop-linux                                                   unix:///Users/dlovison/.docker/run/docker.sock                                                                 
my-remote-engine2 *                                             ssh://vagrant@192.168.56.6                                       

When I execute my test

16:25:20,932 ERROR (testng-ExampleJdg4931) [org.testcontainers.dockerclient.DockerClientProviderStrategy] Could not find a valid Docker environment. Please check configuration. Attempted configurations were:
16:25:20,932 ERROR (testng-ExampleJdg4931) [org.testcontainers.dockerclient.DockerClientProviderStrategy]     UnixSocketClientProviderStrategy: failed with exception InvalidConfigurationException (Could not find unix domain socket). Root cause NoSuchFileException (/var/run/docker.sock)
16:25:20,933 ERROR (testng-ExampleJdg4931) [org.testcontainers.dockerclient.DockerClientProviderStrategy] As no valid configuration was found, execution cannot continue
diegolovison commented 2 years ago

Require https://github.com/docker-java/docker-java/issues/1946

eddumelendez commented 1 year ago

@diegolovison I think you are using Colima, right? Check the docs on how to set the env vars.

t1 commented 1 year ago

It would be very nice, if Colima would be detected automatically, just like Docker-Desktop is. I assume this is not a political thing 😘

skagedal commented 1 year ago

@t1 I think this assumption is correct. My efforts so far about implementing support for Docker contexts have been well received by the maintainers. I am working on a pull request for docker-java here. Hope to be able to finish it up soon. I am also blogging a bit about my progress, starting here.

chriskilding commented 1 year ago

Is there any update on this? The relevant PR in docker-java was merged a couple of weeks ago and I think they've done a release 3.3.0 with that change included.

Do we just need a new release of testcontainers-java to pick this change up?

skagedal commented 1 year ago

Oh cool, I missed that – indeed 3.3.0 seems to include it. And the dependency in testcontainers-java was also bumped. So yeah, I guess that's what we need!

chriskilding commented 1 year ago

@eddumelendez would you be able to publish a new release? (Alternatively, when does the Testcontainers project have a release scheduled next?)

piotrwielgolaski-tomtom commented 1 year ago

I build custom release locally, but it does not work out of box, so anyway some adjustment need to be done to make it work before release

skagedal commented 1 year ago

@piotrwielgolaski-tomtom Could you provide some details on what you tried and in what you saw?

piotrwielgolaski-tomtom commented 1 year ago

@skagedal my scenario was simple, use docker context to connect with remote docker instance. when I rebuild latest code I wanted to give a try, but it don't work. it seems that test containers have concept of DockerClientProviderStrategy, but any of existing one will take into account context set by docker, maybe EnvironmentAndSystemPropertyClientProviderStrategy requires same extension or extra strategy need to be added

piotrwielgolaski-tomtom commented 1 year ago

I take another swing on this and simple change in EnvironmentAndSystemPropertyClientProviderStrategy https://github.com/piotrwielgolaski-tomtom/testcontainers-java/blob/de1324ed2800eff4da326d0c23d281399d006bc0/core/src/main/java/org/testcontainers/dockerclient/EnvironmentAndSystemPropertyClientProviderStrategy.java#L51

            case "autoIgnoringUserProperties":
                dockerClientConfig = configBuilder.build();
                applicable = dockerClientConfig.getDockerHost() != null;
                break;

make it work a bit more, but you need to opt in for dockerconfig.source=autoIgnoringUserProperties

@skagedal I noticed that you focused on docker host, but all TLS is missing, so when I use remote connection over tcp with tls it will not work. It would be lovely if docker-java also support resolution of getSSLConfig based on context

skagedal commented 1 year ago

@piotrwielgolaski-tomtom Right, there is a SkipTLSVerify boolean property in the context that also should have been taken into account. I missed/forgot that. When you say "all TLS", do you mean other things as well?

skagedal commented 1 year ago

Oh, there is a TLSMaterial property... https://docs.docker.com/engine/context/working-with-contexts/

I never found any complete documentation on this format, does anyone know what that might be?

piotrwielgolaski-tomtom commented 1 year ago

@skagedal The best that I can find https://github.com/docker/cli/blob/a0756c3c2cacebf5e5dc6454cc280c3ddf675176/docs/reference/commandline/context_inspect.md?plain=1#L42 I thin that this path if exist should be used for SSL config, of course if skip is not true.

skagedal commented 1 year ago

And what would it expect to find in that path?

piotrwielgolaski-tomtom commented 1 year ago

And what would it expect to find in that path?

I would expect that whatever docker expects to configure SSL https://github.com/skagedal/docker-java/blob/88cea47d18cce4339a202ae7ad66fe68ee00d533/docker-java-core/src/main/java/com/github/dockerjava/core/DefaultDockerClientConfig.java#LL450C58-L450C72 It should be directory with certificate

glasser commented 1 year ago

Now that 1.8.0 is out which uses docker-java 3.3, is this supposed to work out of the box? It's not working for me but maybe I'm doing something wrong.

piotrwielgolaski-tomtom commented 1 year ago

It does not work out of box, I wrote details above.

glasser commented 1 year ago

Ah cool — is there a PR open for that last bit? Is that something I can work around as a user without forking testcontainers?

glasser commented 1 year ago

While I don't know if this supports all context use cases, #6927 is sufficient to support Colima without any configuration.

g0t4 commented 1 year ago

FYI in the latest build of Docker Desktop for macOS it no longer automatically sets/updates /var/run/docker.sock

Could not find a valid Docker environment. Please check configuration. Attempted configurations were: ...
(Could not find unix domain socket). Root cause NoSuchFileException (/var/run/docker.sock)

If testcontainers supported contexts, I could use docker context use desktop-linux which points to a user specific socket: unix:///Users/$USER/.docker/run/docker.sock

dominik-kovacs commented 1 year ago

what is the current status?

OscarPalafox commented 7 months ago

In https://github.com/testcontainers/testcontainers-java/pull/5039, @kiview and @bsideup both mention it is possible to do it with custom Docker configurations. Would it be possible to please get some guidance on how to achieve this?