Open jobayle opened 4 months ago
Will this be fixed any time soon?
Also relevant for #7871 there was a solution proposed in the issue as well
Hi @EAlf91, I cannot find the solution in the linked issue, could you please add a link to the specific comment? thanks!
@jobayle It's mentioned here: https://github.com/testcontainers/testcontainers-java/issues/7871#issuecomment-2041169911 but it would require a change I guess. The author made the hook configurable via spring properties: https://github.com/alex-arana/testcontainers-java/commit/a0fcbdf001ee17b5649882052ec62ad7092d1a74
I didn't try it myself and didn't see any way to configure this without using this fork. I'd highly appreciate to see a revert of #7717 or maybe using this way to configure it via spring properties
Thanks @EAlf91, but imho, this is not a viable solution if we have to maintain a patched version of testcontainers.
Any progress on this issue?
Module
Core
Testcontainers version
1.19.7
Using the latest Testcontainers version?
Yes
Host OS
Linux, Windows
Host Arch
x86_64
Docker version
What happened?
Dears,
With the introduction of this feature: #7717
The ryuk instance is terminated by a shutdown hook, therefore all containers are closed very early.
This prevents other shutdown hooks (eg: those set by the spring framework) to perform actions needed for a graceful shutdown that still require containers to be up. Due to a retry mechanism in Spring's shutdown hook, it greatly increases the overall time to run tests!
Could you please revert this change or introduce a mean to disable this shutdown hook, thanks!
Relevant log output
No response
Additional Information
No response