testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.

https://testcontainers.org

MIT License

7.99k stars 1.64k forks source link

GH-8558 Make Ryuk shutdown hook configurable. #8732

Open mmaeller opened 4 months ago

mmaeller commented 4 months ago

Description

7717 added the Ryuk shutdown hook. Unfortunately, this leads to some issues e.g. with spring-boot like #8558.

With this PR I want to make the initial feature configurable.

s-jepsen commented 3 months ago

Any progress on this issue?

ahmed-marzook commented 2 months ago

Any update?

s-jepsen commented 1 month ago

Any progress on this issue?

alex-arana commented 1 month ago

Why is this PR still in the freezer after nearly 3 months?

Has any feedback been provided as to why the proposed change has not yet been approved? Are there any concerns on the part of the reviewers that we could work through? The way I read it, this change is purely about adding a configurable option to testcontainers configuration such that we can bypass an early termination of the containers and Spring Application Context beans that use those services can coalesce gracefully. Why is this so controversial?

jpalaz commented 1 month ago

@eddumelendez Could you please take a look please?

mariuszptasinskii commented 1 week ago

Any updates? Is there a way to move forwards with this change?