search

testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.org
MIT License
7.89k stars 1.62k forks source link

use customized wait strategy in jdbc container #8759

Open whhe opened 1 month ago

whhe commented 1 month ago

Now the abstract class JdbcDatabaseContainer never uses the waitStrategy option, and I think it's better to use the user defined wait strategy when the waitStrategy field is modified.

whhe commented 1 month ago

Seems the last commit fails the japicmp check. Should I add these deleted methods to methodExcludes list? @eddumelendez

whhe commented 3 weeks ago

I reverted the latest commit of deleting the waitUntilContainerStarted method, so we can deal with it and the japicmp check later.

whhe commented 3 weeks ago

docker pull quay.io/testcontainers/ryuk:latest got exception:

latest: Pulling from testcontainers/ryuk
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of quay.io/testcontainers/ryuk:latest to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/
whhe commented 1 week ago

@eddumelendez PTAL

whhe commented 22 hours ago

I just found #8127 which is trying to fix the same issue, feel free to accept it if you think it's better. @eddumelendez