testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.org
MIT License
7.89k stars 1.62k forks source link

fix LocalStack legacy mode detection for "latest" tag variations #8774

Closed alexrashed closed 1 week ago

alexrashed commented 3 weeks ago

Motivation

While looking into #7390 and digging into the legacy mode check for LocalStack I stumbled upon an issue when using specific latest images, like:

If this is the case, the default fallback currently is to jump back to useLegacyMode=true which is not compatible with up-to-date images. In the long run, I would propose to change the default fallback (as mentioned in https://github.com/testcontainers/testcontainers-java/issues/7390#issuecomment-2163055356), but this PR aims at fixing the issue for these specific tags for now.

Changes

eddumelendez commented 1 week ago

Thanks for your contribution, @alexrashed !