feat: Change the class used by the Oracle database driver

testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.

https://testcontainers.org

MIT License

7.99k stars 1.64k forks source link

feat: Change the class used by the Oracle database driver #8796

Closed cdouillard closed 3 months ago

cdouillard commented 3 months ago

HikariCP logs a Warning when using the oracle.jdbc.driver.OracleDriver class. The use of the oracle.jdbc.OracleDriver class is now recommended (see https://stackoverflow.com/questions/6202653/difference-between-oracle-jdbc-driver-classes/6202721#6202721).

eddumelendez commented 3 months ago

are both drivers offered in the same jar? I think for compatibility reason we should do something like this

eddumelendez commented 3 months ago

@cdouillard do you mind updating the PR addressing my previous comment?

cdouillard commented 3 months ago

Yes they are part of the same jar, i look at the following jars :

com.oracle.database.jdbc:ojdbc8
com.oracle.database.jdbc:ojdbc10
com.oracle.database.jdbc:ojdbc11

These three jars are the ones listed by Oracle : https://www.oracle.com/database/technologies/maven-central-guide.html.

cdouillard commented 3 months ago

@eddumelendez , i just applied your suggestion.

eddumelendez commented 3 months ago

Thanks for your contribution, @cdouillard !