search

testcontainers / testcontainers-java

Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.org
MIT License
8.02k stars 1.65k forks source link

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #8987

Closed jedla97 closed 3 months ago

jedla97 commented 3 months ago

Updating SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is marked deprecated for some time (I see this note in MSSQL 2017 docs). To see that note you can look here https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

eddumelendez commented 3 months ago

Thanks for your contribution, @jedla97 ! Do you know if there is a specific version where that env var was added? Just asking in order to see if we can avoid breaking changes to consumers

jedla97 commented 3 months ago

@eddumelendez I didn't find it in release notes, but I run it with 2017 version and it work start fine. As I didn't find 2016 version I can say for sure it will be working there. By https://endoflife.date/mssqlserver the 2016 have only security support.

eddumelendez commented 3 months ago

Thanks, @jedla97 !