Closed lukaseder closed 1 year ago
Hi @lukaseder
Thanks for the suggestions. As you suggested, moving jOOQ related config inside <jooq>...</jooq>
would be less confusing for people.
@romchellis would you like to work on these changes? If we can incorporate these changes by next week we can release 0.0.2 along with these changes.
Hi @sivaprasadreddy , @lukaseder . I like suggested approach. Actually I'am already looking on possible solutions.Not sure that it will be completed by monday, possibly by the end of next week.
The plugin configuration looks like this:
I think it would be more clear to put jOOQ stuff inside a jOOQ element. I'm aware that this would produce an apparently unnecessary additional level of nesting, but:
<generator/>
isn't a top level element. While<jdbc/>
isn't necessary in most cases, it may be in some (e.g. to pass additional properties to the JDBC connection)<skip/>
,<logging/>
,<onError/>
,<onUnused/>
,<configurationFile/>
, and others that might be added in the future, which you won't support out of the box unless you nest jOOQ's configuration in a<jooq/>
element. Note, you could add support for these in your own top level, but then that would be confusing as it wouldn't be clear if e.g.<skip/>
belongs to jOOQ, or to you.