testcontainers / testcontainers-jooq-codegen-maven-plugin

jOOQ code generator using Testcontainers
Apache License 2.0
56 stars 9 forks source link

Consider moving jOOQ configuration stuff into a jooq element #12

Closed lukaseder closed 1 year ago

lukaseder commented 1 year ago

The plugin configuration looks like this:

<configuration>
        <!-- Plugin configuration -->
    <database>
    </database>

        <!-- delegation to flyway configuration -->
    <flyway>
    </flyway>

        <!-- delegation to liquibase configuration -->
    <liquibase>
    </liquibase>

        <!-- jooq configuration ? -->
    <generator>
        <database>
            <includes>.*</includes>
            <excludes>flyway_schema_history</excludes>
            <inputSchema>public</inputSchema>
        </database>
        <target>
            <packageName>org.jooq.codegen.maven.example</packageName>
            <directory>target/generated-sources/jooq</directory>
        </target>
    </generator>
</configuration>

I think it would be more clear to put jOOQ stuff inside a jOOQ element. I'm aware that this would produce an apparently unnecessary additional level of nesting, but:

sivaprasadreddy commented 1 year ago

Hi @lukaseder Thanks for the suggestions. As you suggested, moving jOOQ related config inside <jooq>...</jooq> would be less confusing for people.

@romchellis would you like to work on these changes? If we can incorporate these changes by next week we can release 0.0.2 along with these changes.

romchellis commented 1 year ago

Hi @sivaprasadreddy , @lukaseder . I like suggested approach. Actually I'am already looking on possible solutions.Not sure that it will be completed by monday, possibly by the end of next week.