search

testcontainers / testcontainers-jooq-codegen-maven-plugin

jOOQ code generator using Testcontainers
Apache License 2.0
49 stars 10 forks source link

Scope of most dependencies should be optional #21

Closed simasch closed 1 year ago

simasch commented 1 year ago

I just noticed that most of the dependencies have default scope, and a build will download JDBC drivers, Liquibase etc. even if they are not used!

What do you think to make non mandatory and the user has to those if needed?

romchellis commented 1 year ago

Since it is maven plugin they will be not included to final jar

romchellis commented 1 year ago

Hi @simasch, what are your thoughts on the comment above? In fact, it is not possible to conditionally load dependencies depending on plugin properties. Furthermore, they don't pollute the target jar; plugin dependencies are safe for the caller's project. Should we close the issue?

simasch commented 1 year ago

Hi @romchellis Sure 😅 It looks like I was a bit confused when writing this issue. Sorry about that.

romchellis commented 1 year ago

Hi @romchellis Sure 😅 It looks like I was a bit confused when writing this issue. Sorry about that.

No worries, I was not a familiar with maven plugins that deep before as well until I took this project :)

simasch commented 1 year ago

The thing is that I maintain a Maven plugin myself and should be well aware of that (shame on me).