search

testcontainers / testcontainers-node

Testcontainers is a NodeJS library that supports tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.
https://testcontainers.com
MIT License
1.94k stars 195 forks source link

Docs - make info about Wait Strategies easier to find #846

Closed osher closed 3 weeks ago

osher commented 1 month ago

When I was searching for it - I almost missed it, and found it by accident a moment before I gave up.

I believe it's a too important feature to be left only in the advanced-features page.

I tried my best to understand the order by which items appear in the containers page and tried to fit in.

I hope you accept this :)

netlify[bot] commented 1 month ago

Deploy Preview for testcontainers-node ready!

Name Link
Latest commit 5cc8bb512abb79d1c2ecf522784d31db35e9209a
Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6718ab9ca2c63a0008dd235d
Deploy Preview https://deploy-preview-846--testcontainers-node.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

osher commented 1 month ago

If you point me to the language-agnostic docs - I'll see if I can PR the same thing there :)

cristianrgreco commented 3 weeks ago

Hi,

I believe it's a too important feature to be left only in the advanced-features page.

The docs for wait strategies aren't in the advanced page. They have their own top-level page

image

I'd rather avoid duplicating the docs for the time being. If I hear again that someone's missed the page then I'll revisit this.

Thanks for raising 🙂