search

testcontainers / testcontainers-php

https://www.testcontainers.org implementation for PHP
MIT License
99 stars 17 forks source link

Added support to specify the network used by container #5

Closed smurfy closed 8 months ago

smurfy commented 8 months ago

I'm using ddev and need to have the testcontainer in the same network, so with this PR you can specify the docker network it should use.

Also useful in other cases where docker compose is used.

Basically like: https://github.com/testcontainers/testcontainers-java/blob/main/core/src/main/java/org/testcontainers/containers/Container.java#L283

smurfy commented 8 months ago

Anything i need to fix for the piplines to pass? Looks like an unrelated issue

shyim commented 8 months ago

Yes it is unrelated

smurfy commented 8 months ago

Ok, cool any chance to get it tagged? to use non git url in my composer to install :)

shyim commented 8 months ago

sure I tagged it :) https://github.com/shyim/testcontainer/releases/tag/0.1.1

thank you again! :)