Open vikahl opened 2 years ago
Yes, that's probably a good idea because we already support all the other (less commonly used) arguments through keyword arguments. Are you open to submitting a PR?
Regarding GenericContainer
, I deprecated it because it's the same as DockerContainer
just with a different name.
I'm happy to submit a PR!
Submitted a PR, happy for a review.
First I want to thank you for this very nice and convenient library.
Background
I am using the library for smoke tests for microservices. In these tests I spin up a container and make sure I can e.g., fetch an endpoint and see that the container is built and starts correctly.
The library provides all convenient methods, except for a way to set e.g., ports and env variables in the context manager. To solve this I have subclassed
testcontainers.core.container.DockerContainer
into a class as below:and use it as
Proposal
name
,ports
,env
,volumes
, … can be set as init variables.I saw #114 that removed the previous
GenericContainer
but I don't see a motivation why it was done and why it could not be extended.