search

testcontainers / testcontainers-python

Testcontainers is a Python library that providing a friendly API to run Docker container. It is designed to create runtime environment to use during your automatic tests.
https://testcontainers-python.readthedocs.io/en/latest/
Apache License 2.0
1.51k stars 281 forks source link

fix(core): add empty _configure to DockerContainer #556

Closed christianaaronschroeder closed 3 months ago

christianaaronschroeder commented 4 months ago

I've used DbContainer in the past as a parent to a class where I redefined _configure() and did not redefine start(). I'm now using DockerContainer and wanted to follow the same pattern but it doesn't have a _configure() function called in start(). I figure this gives the easy option without being invasive?

tests pass

alexanderankin commented 3 months ago

ok, its in the java version - https://github.com/testcontainers/testcontainers-java/blob/18ea976a640e43e3fa1a1da7285c4630fd9cdbac/core/src/main/java/org/testcontainers/containers/GenericContainer.java#L701 - , i say why not