search

testcontainers / testcontainers-python

Testcontainers is a Python library that providing a friendly API to run Docker container. It is designed to create runtime environment to use during your automatic tests.
https://testcontainers-python.readthedocs.io/en/latest/
Apache License 2.0
1.44k stars 270 forks source link

fix: Container for Milvus database #606

Closed nightblure closed 1 month ago

nightblure commented 1 month ago

I use this wonderful package for writing tests, but I did not find a container for Milvus vector database

Please check, I'm ready to correct comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@f5a019b). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #606 +/- ## ======================================= Coverage ? 75.18% ======================================= Files ? 10 Lines ? 548 Branches ? 77 ======================================= Hits ? 412 Misses ? 110 Partials ? 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nightblure commented 1 month ago

@alexanderankin thanks for your edits! Is there anything else required from me or is this solution suitable?

alexanderankin commented 1 month ago

if it looks good to you it looks good to me

nightblure commented 1 month ago

if it looks good to you it looks good to me

I think it's good