Closed Weasy666 closed 2 years ago
Could you possibly put shiplift behind a feature flag?
The proper fix for this would be upstream: https://github.com/softprops/shiplift/issues/241
As a work-around, we can conditionally set the necessary features on shiplift based on the target platform. I currently don't have time to do this but happy to merge a PR for this if it is important to you that dev
works on Windows. Alternatively, I'd recommend to use the latest release.
On windows docker talks named pipes.
When running the
dev
-branch on Windows, i get a few errors regardingtokio::net::UnixListener
, like thisWhich makes perfect sense, because the Unix stuff does not work on Windows. As far as u could tell,
hyperlocal
is a dependency ofshiplift
and not necessary for theCli
implementation. Could you possibly putshiplift
behind a feature flag? That would enable us to compile and usetestcontainers
with itsCli
feature.