search

testcontainers / testcontainers-rs

A library for integration-testing against docker containers from within Rust.
https://rust.testcontainers.org
Apache License 2.0
745 stars 142 forks source link

refactor!: rename `RunnableImage` to `ContainerRequest` #653

Closed DDtKey closed 4 months ago

DDtKey commented 4 months ago

I decided to go with renaming because it's a good moment: we've provided ImageExt trait in order to avoid direct usage of RunnableImage when possible. Renaming seems to be minor issue in contrast of other changes.

This is semantically more correct, it allows to customize some parameters of a container to create, but not the image itself (network, shm_size, cgroupns etc.). Subjectively, it's more obvious to see ContainerRequest<Redis> instead of RunnableImage<Redis>. Also, it's similar to Testcontainers for Go.

netlify[bot] commented 4 months ago

Deploy Preview for testcontainers-rust ready!

Name Link
Latest commit 896f1c9bf9ed32e9f8cf400e76654ede5b3324c6
Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/66697d64280cda0008a8c0c2
Deploy Preview https://deploy-preview-653--testcontainers-rust.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.