perf: use separate dropper thread for `current_thread` flavor

testcontainers / testcontainers-rs

A library for integration-testing against docker containers from within Rust.

https://rust.testcontainers.org

Apache License 2.0

697 stars 133 forks source link

perf: use separate dropper thread for `current_thread` flavor #666

Closed DDtKey closed 2 months ago

DDtKey commented 2 months ago

tokio::test uses current_thread flavor by default and it's typical use-case.

However, we need to perform some async operations on drop, and it used to spawn a new thread for each drop. It's inefficient and was a temporary solution.

Now, it uses:

for multi-thread runtime flavor: tokio::task::block_in_place
for current-thread runtime flavor: lazily spawns a separate thread for dropping tasks, thus it will be only 1 thread regardless of the number of containers, networks, etc.

netlify[bot] commented 2 months ago

Deploy Preview for testcontainers-rust ready!

Name	Link
Latest commit	849b036b74938b443f759439d38f2f947b29a1f6
Latest deploy log	https://app.netlify.com/sites/testcontainers-rust/deploys/667071bb95e19100087f6150
Deploy Preview	https://deploy-preview-666--testcontainers-rust.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

testcontainers / testcontainers-rs

perf: use separate dropper thread for `current_thread` flavor #666

✅ Deploy Preview for testcontainers-rust ready!

Deploy Preview for testcontainers-rust ready!