Support customize CMD for GenericImage

testcontainers / testcontainers-rs

A library for integration-testing against docker containers from within Rust.

https://rust.testcontainers.org

Apache License 2.0

724 stars 143 forks source link

Support customize CMD for GenericImage #701

Closed tisonkun closed 2 months ago

tisonkun commented 3 months ago

I can see that we support customize entrypoint. Is there any blocker from supporting CMD also?

DDtKey commented 3 months ago

Hi there 👋

I think there is no blockers for this, and it's currently supported with ImageExt::with_cmd In general, ImageExt was introduced to unify the interface and make overrides simpler for any Image. Documentation will be improved in the near future.

But we can consider extending GenericImage too.

DDtKey commented 2 months ago

I'm going to close the issue due to reasons described in the PR.

Currently, ImageExt provides this functionality and makes API more consistent.

Please, re-open if you feel there are missing arguments.

Thank you 🙏