Closed blaenk closed 1 month ago
Name | Link |
---|---|
Latest commit | 58a8ce18b9db5b4199455da3b4d11be09e32fd7f |
Latest deploy log | https://app.netlify.com/sites/testcontainers-rust/deploys/66a6b24e30e8fa00087e4eae |
Deploy Preview | https://deploy-preview-709--testcontainers-rust.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thank you for the contribution and well-described issue! 🚀
I will add windows runner into test-suite (matrix in CI) separately, preferably before merging this
Could you apply rustfmt
and check falling tests?
Overall, looks like LGTM 🙏
Done! Thanks for reviewing.
This is one way to fix https://github.com/testcontainers/testcontainers-rs/issues/708
Although we still parse into a
Url
, we don't pass that value on to clients, sinceUrl
may mutate the input, which in the case of #708, breaks WindowsNamedPipeConnector
, which is the default way of connecting to the Docker daemon.I also disabled the SCTP tests on Windows since it doesn't seem there's support for that on Windows.