search

testcontainers / testcontainers-rs

A library for integration-testing against docker containers from within Rust.
https://rust.testcontainers.org
Apache License 2.0
697 stars 133 forks source link

fix: don't assume docker host is a url #709

Closed blaenk closed 1 month ago

blaenk commented 1 month ago

This is one way to fix https://github.com/testcontainers/testcontainers-rs/issues/708

Although we still parse into a Url, we don't pass that value on to clients, since Url may mutate the input, which in the case of #708, breaks Windows NamedPipeConnector, which is the default way of connecting to the Docker daemon.

I also disabled the SCTP tests on Windows since it doesn't seem there's support for that on Windows.

netlify[bot] commented 1 month ago

Deploy Preview for testcontainers-rust ready!

Name Link
Latest commit 58a8ce18b9db5b4199455da3b4d11be09e32fd7f
Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/66a6b24e30e8fa00087e4eae
Deploy Preview https://deploy-preview-709--testcontainers-rust.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DDtKey commented 1 month ago

Thank you for the contribution and well-described issue! 🚀

I will add windows runner into test-suite (matrix in CI) separately, preferably before merging this

DDtKey commented 1 month ago

Could you apply rustfmt and check falling tests?

Overall, looks like LGTM 🙏

blaenk commented 1 month ago

Done! Thanks for reviewing.