search

testdockerwcsim / XTriggerApplication

Other
2 stars 3 forks source link

Make Setup.sh sourceable from other directories. #28

Closed ast0815 closed 4 years ago

ast0815 commented 4 years ago

The hardcoded source of /root/HyperK/root/bin/thisroot.sh is still a bit annoying, but I'll leave that for someone else to make more universal.

tdealtry commented 4 years ago

Thanks for this @ast0815! FYI the binning of /root/HyperK/root/bin/thisroot.sh is in #27

ast0815 commented 4 years ago

Seems like the docker container does not know the command realpath. From the TravisCI log:

./Setup.sh: line 5: realpath: command not found
ast0815 commented 4 years ago

Is there anything keeping this from being merged at this point?

brichards64 commented 4 years ago

what is the point of build.h ?

i know you didnt add it its an update that was pulled in that i missed but what is the point of it?

federiconova commented 4 years ago

It defines the type to be used for some variables

On 02/04/2020 13:41, brichards64 wrote:

what is the point of build.h ?

i know you didnt add it its an update that was pulled in that i missed but what is the point of it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/HKDAQ/TriggerApplication/pull/28#issuecomment-607821592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJRPQ3SIN4DV2F5OJOSFH3RKSBWJANCNFSM4LAOJOTA.

--

Federico Nova office: R1 2.89 phone: 01235 44 6265 email: federico.nova@stfc.ac.uk

Particle Physics Department Rutherford Appleton Laboratory Harwell, Didcot, Oxford, OX11 0QX, UK

tdealtry commented 4 years ago

Build.h is the way we're turning on/off tools that require external libraries (BONSAI, energetic BONSAI) on/off

brichards64 commented 4 years ago

ok i which case PR approved