Rewrite DataOut & fix a big memory leak

[tdealtry]

• WCSimReader was leaking badly; fixed with TBranch::SetAutoDelete(kTRUE)
• DataOut::Finalise() was seg faulting. Fixed by making the TFile a TFile * (yes I don't understand either...)
• The event num/filename from the original root file is now a single entry, rather than multiple (now we can have big events in WCSim, don't have to implement event stacking in TriggerApplication). This fixes a memory leak there
• DataOut is rewritten. Instead of hacking together a WCSimRootEvent out of the ashes of the input one, it creates a new one and fills it sensibly
  • The output is almost identical to the old version. In a test of 10 events, 3 aren't completly identical to the old version, and they seem to be hits at the edge of the trigger readout window. I'm reluctant to spend more time on this, since #49 is going to make finding hit times obsolete anyway (or at least, pushes the problem into a different tool...)
  • The file looks mostly like a WCSim file, however the true tracks are all in trigger 0 (rather than spread around the triggers like WCSim does). I can probably do what WCSim does, but to me that's a more confusing layout. Thoughts?
  • It should now work for data (i.e. when not using WCSimReader), with the caveat that the geometry tree is a "todo"
• DataOut now adheres to the new coding conventions, and tries to use "hit" instead of "digit" for consistency with the rest of TriggerApplication

Note this requires the WCSim branch https://github.com/tdealtry/WCSim/tree/leak

[tdealtry]

One more thing... there's still a WCSimReader memory leak, but only when TChaining multiple files together. It doesn't leak with a single big file. I've not worked out why. If anyone has seen something like this before, please speak up! Otherwise, I think we ignore it for the purposes of this PR

[brichards64]

Travis failed can you fix this bug?

UserTools/Factory/../DataOut/DataOut.cpp:380:18: error: 'class WCSimRootCherenkovDigiHit' has no member named 'SetPhotonIds'

[tdealtry]

This requires the WCSim branch https://github.com/tdealtry/WCSim/tree/leak

[brichards64]

i see so should we put it on hold until that PR is merged into WCSim?

[tdealtry]

It's not worth merging yet, however we could get the code review finished and be ready for when WCSim/WCSim#286 is merged

[ast0815]

The time handling is not correct, I think. At the very least it mixes TimeDelta and unit-less floating points in strange ways. I'll do a review to check what is going on.

[ast0815]

Also when I run the current version of the code on my SNs, I get a segfault at these lines:

https://github.com/HKDAQ/TriggerApplication/blob/1871ea7085b00ba034a662f61adf817395a9b007/UserTools/DataOut/DataOut.cpp#L251-L253

[tdealtry]

Hopefully d320589 fixes the seg fault

[ast0815]

The segfault seems to be gone now. 👍

[ast0815]

The timing looks ok now. I'll test it with a supernova today or on Monday.

[tdealtry]

Great thanks @ast0815!