testdouble / cypress-rails

Helps you write Cypress tests of your Rails app
Other
321 stars 48 forks source link

fix: clamp puma config to avoid deprecation warning #95

Closed grxy closed 3 years ago

grxy commented 3 years ago

Changes

Calls clamp on the puma config to avoid an issue where the environment value has not been finalized from a proc to a string, leading to a deprecation warning.

searls commented 3 years ago

Does configuration always respond to clamp across all versions of Puma? If not it should be gated behind a respond_to? check, right?

grxy commented 3 years ago

@searls

Does configuration always respond to clamp across all versions of Puma? If not it should be gated behind a respond_to? check, right?

I'll look into this. Thx.

grxy commented 3 years ago

@searls It looks like clamp was already defined as of v3.8.0, which I think is the minimum required by this gem. See https://github.com/puma/puma/blob/v3.8.0/lib/puma/configuration.rb#L211

grxy commented 3 years ago

@searls Any chance I can get a review on this? I confirmed with the author of Puma that clamp has been around since 3.0. Does it make sense that we can skip the respond_to? check since this gem requires puma >= 3.8.0?

searls commented 3 years ago

Sorry for the delay—miscommunication on our end. Landed in 0.5.2!

grxy commented 3 years ago

Thanks so much. Cheers!