search

testdouble / grunt-jasmine-bundle

A "spec" grunt task for Jasmine that includes a standard pack of helpers (jasmine-given, jasmine-stealth, jasmine-only). Uses minijasminenode.
6 stars 4 forks source link

Use @options (not @data) per Grunt guidelines #2

Closed jasonkarns closed 10 years ago

jasonkarns commented 10 years ago

To get target > task > default option merging out of the box, you have to use options when configuring; as opposed to putting the settings directly on the target. Then, within the task, use this.options([defaults]).

searls commented 10 years ago

Hehe, I got those guidelines into the readme because of their use of @data and then I forgot to update this module. Nice

On Sun, Nov 10, 2013 at 3:57 PM, Jason Karns notifications@github.com wrote:

To get target > task > default option merging out of the box, you have to use options when configuring; as opposed to putting the settings directly on the target. Then, within the task, use this.options([defaults]). You can merge this Pull Request by running: git pull https://github.com/jasonkarns/grunt-jasmine-bundle options Or you can view, comment on it, or merge it online at: https://github.com/testdouble/grunt-jasmine-bundle/pull/2 -- Commit Summary --

jasonkarns commented 10 years ago

Fair warning, this isn't backwards compatible. Any task configuration already using the old style won't get picked up correctly.

jasonkarns commented 10 years ago

I tried to tie this PR to #1, but apparently you can only submit PRs to issues created by you.

searls commented 10 years ago

Ah. We could make this BC easily enough

On Sun, Nov 10, 2013 at 4:00 PM, Jason Karns notifications@github.com wrote:

Fair warning, this isn't backwards compatible. Any task configuration already using the old style won't get picked up correctly.

Reply to this email directly or view it on GitHub: https://github.com/testdouble/grunt-jasmine-bundle/pull/2#issuecomment-28160570

jasonkarns commented 10 years ago

Now backwards compatible. (and warns if using the old style config)

davemo commented 10 years ago

:+1:

jasonkarns commented 10 years ago

cleaned up the commits and plucked out the unrelated stuff.

ready to merge

searls commented 10 years ago

Merged on faith