search

testdouble / grunt-jasmine-bundle

A "spec" grunt task for Jasmine that includes a standard pack of helpers (jasmine-given, jasmine-stealth, jasmine-only). Uses minijasminenode.
6 stars 4 forks source link

Multitask behavior was broken #6

Closed searls closed 10 years ago

searls commented 10 years ago

It appears that multi-task behavior was broken by #2 (cc/ @jasonkarns)

If I have two targets defined and I run grunt spec, only the first will actually run. Investigating now.

jasonkarns commented 10 years ago

What was actually broken here? I remember explicitly testing this and thought it worked!?

searls commented 10 years ago

It only worked if the user did not specify a minijasminenode option. Because of the lack of deep merge (re: my other issue), the onComplete got nuked which results in mini jasmine node just running away with the whole process and grunt async() being both useless and uncalled. 

Was mildly infuriating to debug

On Sat, Dec 7, 2013 at 2:04 PM, Jason Karns notifications@github.com wrote:

What was actually broken here? I remember explicitly testing this and thought it worked!?

Reply to this email directly or view it on GitHub: https://github.com/testdouble/grunt-jasmine-bundle/issues/6#issuecomment-30062147