search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

Add rails 4.1.0 support #117

Closed jkndrkn closed 10 years ago

jkndrkn commented 10 years ago

jasmine_rails does not appear to be able to work with rails 4.1.0

bundle exec rake spec:javascripts --trace
** Invoke spec:javascripts (first_time)
** Invoke spec:javascript (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute spec:javascript
rake aborted!
NameError: uninitialized constant ActionController::Integration
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/bundler/gems/jasmine-rails-8aac1f7fd3c3/lib/tasks/jasmine-rails_tasks.rake:15:in `block (2 levels) in <top (required)>'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:240:in `call'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:240:in `block in execute'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:235:in `each'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:235:in `execute'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/2.0.0/monitor.rb:211:in `mon_synchronize'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:201:in `block in invoke_prerequisites'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:199:in `each'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:199:in `invoke_prerequisites'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:178:in `block in invoke_with_call_chain'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/2.0.0/monitor.rb:211:in `mon_synchronize'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/task.rb:165:in `invoke'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:150:in `invoke_task'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:106:in `each'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:106:in `block in top_level'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:115:in `run_with_threads'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:100:in `top_level'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:78:in `block in run'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:176:in `standard_exception_handling'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/lib/rake/application.rb:75:in `run'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/lib/ruby/gems/2.0.0/gems/rake-10.2.2/bin/rake:33:in `<top (required)>'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/bin/rake:23:in `load'
/Users/jderiksen/.rbenv/versions/2.0.0-p353/bin/rake:23:in `<main>'
Tasks: TOP => spec:javascripts => spec:javascript
vinsonchuong commented 10 years ago

I just tried jasmine-rails on Rails 4.1 and Jasmine 2 via http://localhost:3000/specs. It looks like you also need to add jasmine-specs.css to the Rails.application.config.assets.precompile

searls commented 10 years ago

Ah thanks.

On Sun, Apr 13, 2014 at 11:30 PM, Vinson Chuong notifications@github.com wrote:

I just tried jasmine-rails on Rails 4.1 and Jasmine 2. It looks like you also need to add jasmine-specs.css to the Rails.application.config.assets.precompile

Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/issues/117#issuecomment-40330896

searls commented 10 years ago

This was actually caused by the CSS addition in 0.7.0 I bet

On Sun, Apr 13, 2014 at 11:52 PM, Justin Searls searls@gmail.com wrote:

Ah thanks. On Sun, Apr 13, 2014 at 11:30 PM, Vinson Chuong notifications@github.com wrote:

I just tried jasmine-rails on Rails 4.1 and Jasmine 2. It looks like you also need to add jasmine-specs.css to the Rails.application.config.assets.precompile

Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/issues/117#issuecomment-40330896

searls commented 10 years ago

Landed in 0.7.1

jkndrkn commented 10 years ago

Awesome, thanks so much!